A catch block added in 2021 for an error that has not occurred since, swallowing a different one.
// what it was
try {
$this->supplier->dispatch($consignment);
} catch (Throwable $e) {
$this->logger->warning('dispatch failed', ['e' => $e]);
}
// catching Throwable meant a TypeError from our own
// mapper was logged at warning and the job reported
// success. eleven consignments, over two months.
A catch of Throwable is a decision that every possible failure is recoverable, which is almost never true and is never true of a programming error. Narrowing it to the two supplier exceptions turned eleven silent failures into eleven loud ones, retroactively — the log had them at warning and nobody reads warnings.