refactoring – Page 10 – Türker Yıldırım

An invokable validation rule, and the closure it replaced

NoteApril 25, 20232 min read

A closure rule copied into eleven form requests, with two of the copies subtly out of date. The interface is a small improvement over the previous one —…

TypeScript 5, and the decorators we had been faking

Deep diveApril 21, 20239 min read

5.0 in March, decorators that are the standard proposal rather than the old flag, and a build nobody could explain.

Named arguments into a constructor with nine parameters

NoteApril 16, 20232 min read

A report query object with nine constructor parameters, six of them nullable, called from four places with different subsets. Named arguments make the nine-parameter constructor tolerable, and tolerable…

A container we replaced with four functions

Deep diveApril 12, 20238 min read

A package with a dependency injection container, for eleven services, spending 90 ms compiling on a request that does 12 ms of work.

PHPUnit 10, and the event system that replaced listeners

NoteMarch 14, 20232 min read

The old TestListener interface is gone, and the replacement is a set of typed events with subscribers. The typed events are a genuine improvement over a nine-method interface…

The generic PHP does not have, and the analyser that does

Deep diveFebruary 27, 20239 min read

A collection class that returns mixed, and forty call sites asserting the type by hand. Docblock generics, and where they stop being worth it.

The static factory that should have been a constructor

NoteFebruary 23, 20232 min read

A class with six static factory methods and a private constructor, where five of the factories did the same thing with different argument names. Named constructors earn their…

Reading a service in another language well enough to file a bug

NoteFebruary 22, 20232 min read

A service owned by somebody else, in a language I do not write, returning the wrong value — and “it is broken” is not a bug report. Reading…

PHPUnit 10, and the listeners that no longer exist

Deep diveFebruary 20, 202314 min read

10.0 in February, a configuration file that has accreted since 2014, and a custom TestListener that the new version has no place for.

A plugin update that changed a hook’s arguments

NoteFebruary 17, 20232 min read

A filter that gained a fourth argument, and our callback declared with three, which is legal and silently receives less than it could. PHP does not complain when…